fixes with linter

roles/dev/tasks/build.yml

@@ -6,4 +6,3 @@
       - ninja-build
       - git
     state: latest
-

roles/dev/tasks/cpp.yml

@@ -1,4 +1,6 @@
-- ansible.builtin.import_tasks: build.yml
+# is done at the main
+# - name: Install build comon deps
+#   ansible.builtin.import_tasks: build.yml
 
 - name: Install tools for cpp dev
   ansible.builtin.dnf5:
@@ -6,7 +8,7 @@
       - make
       - cmake
       - xmake
-      
+
       - clang
       - clang-tools
       - clang-tools-extra
@@ -14,7 +16,7 @@
       - clang-tools-devel
       - clang-tools-extra-devel
       - clang-libs
-      
+
       - doxygen
 
     state: latest

roles/dev/tasks/haskell.yml

@@ -1,19 +1,25 @@
 - name: Download ghcup bootstrap script
   ansible.builtin.uri:
-    url:
-      return_content: yes
+    url: https://get-ghcup.haskell.org
+    return_content: true
   register: ghcup_bootstrap
 
+- name: Check if .ghcup present
+  ansible.builtin.stat:
+    path: '{{ ansible_env.HOME }}/.ghcup'
+  register: ghcup_dir
+
+# TODO: detect fish install ??
 - name: Install ghcup, stack, lsp server
-  ansible.builtin.shell:
-    cmd: sh
-    stdin: {{ ghcup_bootstrap.content }}
-    environment:
-      SHELL: /usr/bin/fish # TODO: detect fish install ??
-      BOOTSTRAP_HASKELL_NONINTERACTIVE: 1
-      BOOTSTRAP_HASKELL_GHC_VERSION: latest
-      BOOTSTRAP_HASKELL_CABAL_VERSION: latest
-      BOOTSTRAP_HASKELL_INSTALL_STACK: 1
-      BOOTSTRAP_HASKELL_INSTALL_HLS: 1
-      BOOTSTRAP_HASKELL_ADJUST_BASHRC: P
-      
+  ansible.builtin.shell: |
+      SHELL='/usr/bin/fish'
+      BOOTSTRAP_HASKELL_NONINTERACTIVE=1
+      BOOTSTRAP_HASKELL_GHC_VERSION=latest
+      BOOTSTRAP_HASKELL_CABAL_VERSION=latest
+      BOOTSTRAP_HASKELL_INSTALL_STACK=1
+      BOOTSTRAP_HASKELL_INSTALL_HLS=1
+      BOOTSTRAP_HASKELL_ADJUST_BASHRC=P
+      {{ ghcup_bootstrap.content }}
+  args:
+    executable: /bin/sh
+  changed_when: not ghcup_dir.stat.exists

roles/dev/tasks/js.yml

@@ -11,15 +11,18 @@
       - curl
     state: latest
 
+# TODO: use curl script ??
 - name: Install bun
-  ansible.builtin.shell:
-  cmd: npm install -g bun
+  ansible.builtin.command:
+    cmd: npm install -g bun
+  changed_when: true # change is checked inside npm
 
 - name: Get programs list to check fish presence
   ansible.builtin.package_facts:
     manager: auto
 
-- name: Update fish path
-  ansible.builtin.shell:
-  cmd: echo 'fish_add_path {{ ansible_env.HOME }}/.bun/bin'
-  when: "'fish' in ansible_facts.packages"
+- name: Update fish path for bun
+  ansible.builtin.shell: fish_add_path {{ ansible_env.HOME }}/.bun/bin
+  args:
+    executable: /usr/bin/fish
+  changed_when: true # change is checked inside fish_add_path

roles/dev/tasks/lang.yml

@@ -0,0 +1,10 @@
+- name: Install c++ build tools
+  ansible.builtin.import_tasks: cpp.yml
+
+- name: Install tools for lang dev
+  ansible.builtin.dnf5:
+    name:
+      - tree-sitter-cli
+      - libtree-sitter
+      - libtree-sitter-devel
+    state: latest

roles/dev/tasks/main.yml

@@ -1,18 +1,24 @@
-- ansible.builtin.import_tasks: build.yml
+- name: Common build utils
+  ansible.builtin.import_tasks: build.yml
 
-- ansible.builtin.import_tasks: cpp.yml
+- name: C++ dev environment
+  ansible.builtin.import_tasks: cpp.yml
   when: "'cpp' in tools"
 
-- ansible.builtin.import_tasks: js.yml
+- name: JavaScript dev envronment
+  ansible.builtin.import_tasks: js.yml
   when: "'js' in tools"
 
-- ansible.builtin.import_tasks: haskell.yml
+- name: Haskell dev environment
+  ansible.builtin.import_tasks: haskell.yml
   when: "'haskell' in tools"
 
-- ansible.builtin.import_tasks: txt.yml
+- name: Text writing (typst) environment
+  ansible.builtin.import_tasks: txt.yml
   when: "'txt' in tools"
 
-- ansible.builtin.import_tasks: lang.yml
+- name: Language development environment
+  ansible.builtin.import_tasks: lang.yml
   when: "'lang' in tools"
 
-# TODO: ocaml, truffle, ...
+# TODO: ocaml, truffle, coq ...

roles/dev/tasks/txt.yml

@@ -3,16 +3,16 @@
     user: typst
     repo: typst
     action: latest_release
-    register: typst_version
+  register: typst_version
 
 - name: "Installing typst {{ typst_version.tag }}"
   become: true
   ansible.builtin.unarchive:
-    remote_src: yes
+    remote_src: true
     # TODO: insert v before version ??
     src: "https://github.com/typst/typst/releases/download/{{ typst_version.tag }}/typst-x86_64-unknown-linux-musl.tar.xz"
     dest: "/usr/bin/"
-    keep_newer: yes
+    keep_newer: true
     mode: a+x
     extra_opts:
       - --strip=1
@@ -24,17 +24,17 @@
     user: Myriad-Dreamin
     repo: tinymist
     action: latest_release
-    register: tinymist_version
+  register: tinymist_version
 
 - name: "Installing tinymist (typst lsp) {{ tinymist_version.tag }}"
   become: true
   ansible.builtin.unarchive:
-    remote_src: yes
+    remote_src: true
     # TODO: insert v before version ??, rc ??
     src: "https://github.com/Myriad-Dreamin/tinymist/releases/download/{{ tinymist_version.tag }}/tinymist-x86_64-unknown-linux-gnu.tar.gz"
     dest: "/usr/bin/"
     mode: a+x
-    keep_newer: yes
+    keep_newer: true
     extra_opts:
       - --strip=1
       - --no-anchored
@@ -45,17 +45,17 @@
     user: blopker
     repo: codebook
     action: latest_release
-    register: codebook_version
+  register: codebook_version
 
 - name: "Installing codebook (spellcheck lsp) {{ codebook_version.tag }}"
   become: true
   ansible.builtin.unarchive:
-    remote_src: yes
+    remote_src: true
     # TODO: insert v before version ??
     src: "https://github.com/blopker/codebook/releases/download/{{ codebook_version.tag }}/codebook-lsp-x86_64-unknown-linux-musl.tar.gz"
     dest: "/usr/bin/"
     mode: a+x
-    keep_newer: yes
+    keep_newer: true
     extra_opts:
       - --strip=1
       - --no-anchored